Skip to content

test: Add inversePrecedence regression tests#1013

Merged
github-actions[bot] merged 4 commits intomasterfrom
test/inverse-precedence-861-864
Apr 26, 2026
Merged

test: Add inversePrecedence regression tests#1013
github-actions[bot] merged 4 commits intomasterfrom
test/inverse-precedence-861-864

Conversation

@mPokornyETM
Copy link
Copy Markdown
Contributor

Summary

Add two regression tests to LockStepTest that confirm the inversePrecedence queue-ordering bugs reported in #861 (JENKINS-40787) and #864 (JENKINS-41070) are resolved.

New tests

Test Issue What it verifies
lockInverseOrderWithLabel JENKINS-40787 / #861 inversePrecedence=true grants the lock to the newest build when locking by label (b1 → b3 → b2)
lockInverseOrderMixedDifferentJobs JENKINS-41070 / #864 Each waiting job's own inversePrecedence flag controls queue position, not the releasing job's flag. Uses separate pipeline jobs (pA#1 → pA#2 → pB#1 → pB#2)

Testing done

All 31 LockStepTest tests pass locally (0 failures, 0 errors).

Fixes #861
Fixes #864

@mPokornyETM mPokornyETM requested a review from a team as a code owner April 19, 2026 18:53
@mPokornyETM mPokornyETM force-pushed the test/inverse-precedence-861-864 branch 4 times, most recently from 988bb7b to e736ca9 Compare April 21, 2026 19:35
Add two new tests to LockStepTest:

- lockInverseOrderWithLabel: verifies inversePrecedence=true grants the
  lock to the newest build when locking by label (JENKINS-40787, #861)

- lockInverseOrderMixedDifferentJobs: verifies each waiting job's own
  inversePrecedence flag controls queue ordering when using separate
  pipeline jobs with mixed settings (JENKINS-41070, #864)
@mPokornyETM mPokornyETM force-pushed the test/inverse-precedence-861-864 branch from e736ca9 to 0b67e95 Compare April 22, 2026 10:01
mPokornyETM and others added 3 commits April 22, 2026 16:13
Extract lockInverseOrderWithLabel and lockInverseOrderMixedDifferentJobs
into LockStepInversePrecedenceTest to keep LockStepTest smaller and
avoid CI timeouts.
@mPokornyETM mPokornyETM added the merge-in-3-days-without-review Auto-approve countdown label Apr 23, 2026
@github-actions github-actions Bot added merge-in-2-days-without-review Auto-approve countdown and removed merge-in-3-days-without-review Auto-approve countdown labels Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Auto-merge countdown: This PR will be auto-approved in 2 day(s) if no review is submitted.

@github-actions github-actions Bot added merge-in-1-day-without-review Auto-approve countdown and removed merge-in-2-days-without-review Auto-approve countdown labels Apr 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Auto-merge countdown: This PR will be auto-approved in 1 day(s) if no review is submitted.

@github-actions github-actions Bot removed the merge-in-1-day-without-review Auto-approve countdown label Apr 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Auto-approved: No review received within 3 days. Merging now.

@github-actions github-actions Bot added the merged-without-review Auto-approve countdown label Apr 26, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: no review received within 3 days of opening.

@github-actions github-actions Bot merged commit 93b0b9f into master Apr 26, 2026
21 checks passed
@github-actions github-actions Bot deleted the test/inverse-precedence-861-864 branch April 26, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

1 participant